TM: do not populate delivery service disabled locations #6051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disabledLocations array is an unnecessary optimization for Traffic Router, and it isn't always populated properly in certain cases, leading to service outages. Therefore, never populate it, but keep the field around for compatibility purposes.
rawlinp
added
bug
mattjackson220
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
The
disabledLocationsarray is an unnecessary optimization for TrafficRouter, and it isn't always populated properly in certain cases, leading
to service outages. Therefore, never populate it, but keep the field
around for compatibility purposes.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure the TM tests pass.
Shut down all caches in a cachegroup for a CDN, request
GET /publish/CrStatesfrom TM, ensure that thedisabledLocationsarrays are all empty -- i.e.[].If this is a bug fix, what versions of Traffic Control are affected?
5.1.x, master
The following criteria are ALL met by this PR